Re: [PATCH v3 2/2] spi: Introduce new driver for Qualcomm QuadSPI controller

From: Doug Anderson
Date: Fri Sep 28 2018 - 20:19:05 EST


Hi,

On Fri, Sep 28, 2018 at 11:20 AM Ryan Case <ryandcase@xxxxxxxxxxxx> wrote:
> > > + master->max_speed_hz = 300000000;
> > > + master->num_chipselect = QSPI_NUM_CS;
> > > + master->bus_num = pdev->id;
> >
> > Can this come from DT aliases? I've never thought about qspi and
> > "regular" spi being in the same spi bus numbering system, but I suppose
> > that will happen now and we need to make sure that qspi numbers start
> > after the regular ones?
>
> I'm not sure. Can look into it.

In a previous response for the other Qualcomm SPI driver Mark said to
set this to -1. Specifically the code was checking the alias and Mark
said:

> Don't do this, just set bus_num to -1 and let the core assign an ID.

[1] https://lkml.kernel.org/r/20180503233849.GF13402@xxxxxxxxxxxxx

-Doug