Re: [PATCH] perf/x86/intel: Add counter freezing quirk for Goldmont

[Liang, Kan]

On 10/3/2018 10:15 AM, linux-kernel-owner@xxxxxxxxxxxxxxx wrote:
> To make it more generic, I think we also need to extend the struct 
> sku_microcode to check vendor and family.
> The "model" in struct x86_cpu_id is u16. I will also change "model" and 
> "stepping" to u16.
>
> struct sku_microcode {
>  ÂÂÂÂu16 vendor;
>  ÂÂÂÂu16 family;
>  ÂÂÂÂu16 model;
>  ÂÂÂÂu16 stepping;
>  ÂÂÂÂu32 microcode;
> };

No, should be consistent as struct cpuinfo_x86.
The struct sku_microcode should be

struct sku_microcode {
      u8 vendor;
      u8 family;
      u8 model;
      u8 stepping;
      u32 microcode;
};

Thanks,
Kan