Re: [PATCH] perf/x86/intel: Add counter freezing quirk for Goldmont

[Borislav Petkov]

On Wed, Oct 03, 2018 at 10:25:03AM -0400, Liang, Kan wrote:
> 
> 
> On 10/3/2018 10:15 AM, linux-kernel-owner@xxxxxxxxxxxxxxx wrote:
> > To make it more generic, I think we also need to extend the struct
> > sku_microcode to check vendor and family.
> > The "model" in struct x86_cpu_id is u16. I will also change "model" and
> > "stepping" to u16.
> > 
> > struct sku_microcode {
> >  ÂÂÂÂu16 vendor;
> >  ÂÂÂÂu16 family;
> >  ÂÂÂÂu16 model;
> >  ÂÂÂÂu16 stepping;
> >  ÂÂÂÂu32 microcode;
> > };
> 
> No, should be consistent as struct cpuinfo_x86.
> The struct sku_microcode should be
> 
> struct sku_microcode {

And drop that "sku_" prefix. Call this a struct microcode_bl_entry or
so, to be clear what it is.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.