Re: [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier

From: Peter Zijlstra
Date: Thu Oct 04 2018 - 05:37:11 EST


On Thu, Oct 04, 2018 at 10:47:04AM +0200, Rafael J. Wysocki wrote:

> > The comment is irrelevant as the remaining function is used for
> > statistics in addition to the perf multiplier. It does exactly what the
> > function name is.
>
> Which is my point. It shouldn't be dropped entirely, but updated IMO.

But the function name isn't the problem.. the problem that any use of
the number is fundamentally broken.