Re: [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier

From: Rafael J. Wysocki
Date: Thu Oct 04 2018 - 05:42:21 EST


On Thursday, October 4, 2018 11:36:44 AM CEST Peter Zijlstra wrote:
> On Thu, Oct 04, 2018 at 10:47:04AM +0200, Rafael J. Wysocki wrote:
>
> > > The comment is irrelevant as the remaining function is used for
> > > statistics in addition to the perf multiplier. It does exactly what the
> > > function name is.
> >
> > Which is my point. It shouldn't be dropped entirely, but updated IMO.
>
> But the function name isn't the problem.. the problem that any use of
> the number is fundamentally broken.
>

We're in violent agreement here. :-)

I just wanted to say that the comment was still relevant at least with
respect to this function, but the patch was removing the comment
entirely.