Re: [PATCH] regulator: fixed: Use more standard GPIO binding
From: Linus Walleij
Date: Thu Oct 04 2018 - 07:32:29 EST
On Thu, Oct 4, 2018 at 12:50 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote:
>
> > Optional properties:
> > -- gpio: gpio to use for enable control
> > +- gpios: gpio to use for enable control
>
> Are we supposed to be able to have just plain gpios as a standards
> conforming property or would best practice be to call it enable-gpios or
> something?
Oh I didn't think of that really. The gpio-regulator indeed uses
enable-gpio for the same thing. But it complicates things codewise,
as the GPIO line is also optional. I'm a bit uncertain, I tend
to think just "gpios" is fine when the usage is unambigous. but
I don't know what the DT maintainers think.
Yours,
Linus Walleij