Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()

From: Kees Cook
Date: Wed Oct 10 2018 - 10:49:25 EST


On Wed, Oct 10, 2018 at 12:03 AM, Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> On Wed, Oct 10, 2018 at 8:12 AM Joel Stanley <joel@xxxxxxxxx> wrote:
>>
>> On Thu, 27 Sep 2018 at 05:07, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> >
>> > Yeah, that's what I'd linked to in the patchwork URL. Andrew, can you take this?
>>
>> clang built -next is blowing up now that Kees' -Wvla patch has been
>> included. This patch fixes it.
>>
>> Kees, perhaps it should go in your tree along side of the -Wvla patch
>> if no one else wants to take it?
>>
>
> I can take it along in the compiler attributes tree, since that
> touches the compiler*.h stuff. Although that would make it
> not-only-attributes, i.e. slightly lying :-)

Oh, I had assumed Masahiro was going to carry it. If that's not true,
sure I'll pick it up as part of my VLA "series".

-Kees

--
Kees Cook
Pixel Security