Re: [PATCH v2] x86: Use assembly instruction mnemonics instead of .byte streams in arch_hweight.h

From: Borislav Petkov
Date: Sun Oct 14 2018 - 16:30:27 EST


On Sun, Oct 14, 2018 at 10:23:54PM +0200, Uros Bizjak wrote:
> Recently the minimum required version of binutils was changed to 2.20,
> which supports popcnt instruction mnemonics. The patch removes
> corresponding #defines that implement popcnt instructions using target-dependant
> .byte streams and uses unified instruction mnemonics instead.
>
> Tested by building x86_64 and i386 version of the kernel and comparing
> objdump dumps of the pathced and unpatched vmlinux.o. They were the same.
>
> v2: Update commit message to emphasize removal of #defines.
>
> Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
> ---
> arch/x86/include/asm/arch_hweight.h | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)

Thanks.

But with one week before the merge window and this being not nearly
urgent, it'll have to wait for after the merge window.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.