Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

From: Michael Schmitz
Date: Sun Oct 14 2018 - 16:33:28 EST


On 15/10/18 04:47, Christoph Hellwig wrote:

+ *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun);
I think lp should always be non-NULL here.

That indeed appears to be the case these days.

So we can't rely on !lp to detect when probing the bus any longer. What else would be available? Do commands used for device probing also have a tag these days by default?

Do we really need to make that distinction?

Cheers,

ÂÂÂ Michael