Re: [PATCH] net: move ʽ__zerocopy_sg_from_iterʼ prototype to header file <linux/skbuff.h>

From: David Miller
Date: Sat Nov 03 2018 - 02:34:00 EST


From: Mathieu Malaterre <malat@xxxxxxxxxx>
Date: Wed, 31 Oct 2018 12:34:59 +0100

> This makes it clear the function is part of the API. Also this will
> remove a warning triggered at W=1:
>
> net/core/datagram.c:581:5: warning: no previous prototype for ʽ__zerocopy_sg_from_iterʼ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>

It's not part of the "API", and it shouldn't even be exported to
modules.

Only net/core/skbuff.c calls it, and that is never modular.