Re: [PATCH] net: move â__zerocopy_sg_from_iterâ prototype to header file <linux/skbuff.h>

[Mathieu Malaterre]

On Sat, Nov 3, 2018 at 7:34 AM David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Mathieu Malaterre <malat@xxxxxxxxxx>
> Date: Wed, 31 Oct 2018 12:34:59 +0100
>
> > This makes it clear the function is part of the API. Also this will
> > remove a warning triggered at W=1:
> >
> >   net/core/datagram.c:581:5: warning: no previous prototype for â__zerocopy_sg_from_iterâ [-Wmissing-prototypes]
> >
> > Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
>
> It's not part of the "API", and it shouldn't even be exported to
> modules.
>
> Only net/core/skbuff.c calls it, and that is never modular.

OK. I got confused with the EXPORT_SYMBOL(). I'll re-send moving
__zerocopy_sg_from_iter to skbuff.c.

Thanks