Re: [PATCH v1] PCI: Move Rohm vendor ID to generic list

From: Andy Shevchenko
Date: Thu Nov 08 2018 - 07:19:27 EST


On Thu, Nov 8, 2018 at 12:10 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 07, 2018 at 09:58:56PM +0200, Andy Shevchenko wrote:
> > Move the Rohm vendor ID to pci_ids.h from dozen of drivers.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >
> > I believe the best chance to get it merged and be less intrusive to ongoing
> > work is through PCI subsystem as a _fix_ for v4.20.
>
> What? Why? Who cares?

> This can trickle in over the next year or never, as it isn't a bugfix,
> or "necessary" at all. Just add it to pci_ids.h and when that gets
> merged, you can try to remove it from the individual drivers if it
> really is annoying to you.
>

> But this is _NOT_ a fix for anything, don't try to mask it as one, that
> feels like "crying wolf" here :(

It doesn't fix anything, indeed. But since it touches 9 drivers
simultaneously, it might be easier to push it earlier, or other way
around â at the end of the cycle.
OTOH, I don't think there would be conflicts if it goes normal way
through PCI subsystem.

--
With Best Regards,
Andy Shevchenko