Re: [PATCH 1/2] pwm: kconfig: enable kona pwm to be built for cygnus arch

[Thierry Reding]

On Thu, Nov 08, 2018 at 11:47:53AM +0100, ClÃment PÃron wrote:
> Hi Uwe, Scott,
> 
> On Wed, 7 Nov 2018 at 17:48, Scott Branden <scott.branden@xxxxxxxxxxxx> wrote:
> >
> >
> > On 2018-11-07 8:12 a.m., Uwe Kleine-KÃnig wrote:
> > > On Wed, Nov 07, 2018 at 10:36:12AM +0100, ClÃment PÃron wrote:
> > >> The Cygnus architecture use a Kona PWM. This is already present
> > >> in the device tree but can't be built actually. Hence, allow the
> > >> Kona PWM to be built for Cygnus arch.
> > >>
> > >> Signed-off-by: ClÃment PÃron <peron.clem@xxxxxxxxx>
> > >> ---
> > >>   drivers/pwm/Kconfig | 3 ++-
> > >>   1 file changed, 2 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > >> index 763ee50ea57d..76d56fc8b1b7 100644
> > >> --- a/drivers/pwm/Kconfig
> > >> +++ b/drivers/pwm/Kconfig
> > >> @@ -88,7 +88,8 @@ config PWM_BCM_IPROC
> > >>
> > >>   config PWM_BCM_KONA
> > >>      tristate "Kona PWM support"
> > >> -    depends on ARCH_BCM_MOBILE
> > >> +    depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
> > >> +    default ARCH_BCM_CYGNUS
> > > Is it possible to build this driver also on other arches? Then you might
> > > want to consider
> > >
> > >       depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
> > good idea to add the COMPILE_TEST just to increase compile coverage
> 
> Will Do.

This is known to potentially break builds on things like UM where we
have !HAS_IOMEM. Please make sure you thoroughly build-test before you
switch on COMPILE_TEST.

Thierry

Attachment: signature.asc
Description: PGP signature