Re: [PATCH 2/2] ubi: Expose the bitrot interface
From: Richard Weinberger
Date: Thu Nov 08 2018 - 09:31:58 EST
Am Donnerstag, 8. November 2018, 15:26:42 CET schrieb Boris Brezillon:
> On Wed, 7 Nov 2018 23:16:19 +0100
> Richard Weinberger <richard@xxxxxx> wrote:
>
> > +/**
> > + * ubi_bitflip_check - Check an eraseblock for bitflips and scrub it if needed.
> > + * @ubi: UBI device description object
> > + * @pnum: the physical eraseblock to schedule
> > + * @force_scrub: force scrubbing if non-zero, schedule erase otherwise
>
> Are you sure about the "schedule erase otherwise"? I'd say force_scrub
> only influence when the scrub operation is done: either unconditionally
> or depending on the result of ubi_io_read().
True. As often, code and documentation diverged a little.
Thanks,
//richard