Re: [PATCH v2] x86/cpu: fix prototype warning

[Borislav Petkov]

On Thu, Nov 08, 2018 at 04:03:18PM +0100, Borislav Petkov wrote:
> On Thu, Nov 08, 2018 at 09:12:28AM +0800, Yi Wang wrote:
> > This patch fix the following build warnings which because of missing
> > include file:
> > 
> > arch/x86/kernel/cpu/cacheinfo.c:647:6: warning: no previous prototype for âcacheinfo_amd_init_llc_idâ [-Wmissing-prototypes]
> > arch/x86/kernel/cpu/cacheinfo.c:686:6: warning: no previous prototype for âcacheinfo_hygon_init_llc_idâ [-Wmissing-prototypes]
> > arch/x86/kernel/cpu/scattered.c:37:6: warning: no previous prototype for âinit_scattered_cpuid_featuresâ [-Wmissing-prototypes]
> > arch/x86/kernel/cpu/scattered.c:60:5: warning: no previous prototype for âget_scattered_cpuid_leafâ [-Wmissing-prototypes]
> 
> That function is gone in:
> 
> https://git.kernel.org/tip/43500e6f294d175602606c77bfb0d8cd4ea88b4f
> 
> You probably should run your test against tip/master.
> 
> Also, you should say in your commit message that this is an extra
> warning - -Wmissing-prototypes - which is not enabled by default but a
> W=1 one.

And frankly, I don't see why we should be fixing all those. So what if a
global function does't have a previous prototype declaration?!

Micha, is there anything "useful" that warning bitches about or should
we disable it?

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.