Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

From: Arnd Bergmann
Date: Thu Nov 08 2018 - 11:54:46 EST


On Thu, Nov 8, 2018 at 4:47 PM Sven Van Asbroeck <thesven73@xxxxxxxxx> wrote:
> On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > I see this is called from the interrupt handler at the moment, which
> > means you cannot call sleeping functions, but it also means that
> > the timeout may never happen because the timer tick IRQ cannot
> > get through. That means you may have to change the irq handler
> > logic, e.g. to try this a few times but then defer to a bottom half
> > if it fails for a long time.
>
> Touche ! Yes, this is very likely a big problem.
>
> What if I converted the interrupt handler into a threaded interrupt handler?
> That would allow the timer tick to get through, correct?

Yes, with a threaded IRQ handler, the tick comes through, and you can
use a sleeping function to back off between the retries.

Arnd