Re: [PATCH v2 5/7] pinctrl: qcom: spmi-gpio: fix gpio-hog related boot issues

From: Linus Walleij
Date: Fri Nov 09 2018 - 03:59:24 EST


On Thu, Nov 1, 2018 at 1:12 AM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote:

> When attempting to setup up a gpio hog, device probing would repeatedly
> fail with -EPROBE_DEFERED errors. It was caused by a circular dependency
> between the gpio and pinctrl frameworks. If the gpio-ranges property is
> present in device tree, then the gpio framework will handle the gpio pin
> registration and eliminate the circular dependency.
>
> See Christian Lamparter's commit a86caa9ba5d7 ("pinctrl: msm: fix
> gpio-hog related boot issues") for a detailed commit message that
> explains the issue in much more detail. The code comment in this commit
> came from Christian's commit.
>
> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>

No word from Bjorn but I trust my own intuition and applied it.

BjÃrn: shout if it's wrong.

Question: should this also be done for pinctrl-ssbi-gpio.c?

Yours,
Linus Walleij