Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()
From: Juergen Gross
Date: Fri Nov 09 2018 - 10:35:50 EST
On 09/11/2018 16:29, Sander Eikelenboom wrote:
> On 09/11/18 16:20, Juergen Gross wrote:
>> On 09/11/2018 16:02, Sander Eikelenboom wrote:
>>> On 09/11/18 13:04, Juergen Gross wrote:
>>>> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable")
>>>> introduced a regression for Xen guests running fully virtualized
>>>> (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll
>>>> hypercall with interrupts disabled in case of an interrupt (for PV
>>>> guests it does).
>>>>
>>>> So instead of disabling interrupts in xen_qlock_wait() use a nesting
>>>> counter to avoid calling xen_clear_irq_pending() in case
>>>> xen_qlock_wait() is nested.
>>>>
>>>> Fixes: a856531951dc80 ("xen: make xen_qlock_wait() nestable")
>>>> Cc: stable@xxxxxxxxxxxxxxx
>>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>>
>>> Although you don't seem too interested, you can stick on a:
>>> Tested-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
>>> if you like.
>>
>> I am interested.
>>
>> OTOH I wanted to post the patch officially to give others the chance to
>> send remarks.
>
> OK, would be nice to at least be CC'ed on patches going upstream when
> you have been reporting stuff.
Sorry, my fault.
Juergen