Re: [PATCH 2/2] tty: serial: add driver for the SiFive UART

From: Greg Kroah-Hartman
Date: Fri Nov 09 2018 - 12:00:17 EST


On Fri, Nov 09, 2018 at 08:59:51AM -0800, Greg Kroah-Hartman wrote:
> On Thu, Oct 18, 2018 at 04:43:54PM -0700, Paul Walmsley wrote:
> > Add a serial driver for the SiFive UART, found on SiFive FU540 devices
> > (among others).
> >
> > The underlying serial IP block is relatively basic, and currently does
> > not support serial break detection. Further information on the IP
> > block can be found in the documentation and Chisel sources:
> >
> > https://static.dev.sifive.com/FU540-C000-v1.0.pdf
> >
> > https://github.com/sifive/sifive-blocks/tree/master/src/main/scala/devices/uart
> >
> > This driver was written in collaboration with Wesley Terpstra
> > <wesley@xxxxxxxxxx>.
> >
> > Boot-tested on a SiFive HiFive Unleashed A00 board.
> >
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Jiri Slaby <jslaby@xxxxxxxx>
> > Cc: Palmer Dabbelt <palmer@xxxxxxxxxx>
> > Cc: Wesley Terpstra <wesley@xxxxxxxxxx>
> > Cc: linux-serial@xxxxxxxxxxxxxxx
> > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Signed-off-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
> > ---
> > drivers/tty/serial/Kconfig | 24 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/sifive.c | 1070 ++++++++++++++++++++++++++++++
> > include/uapi/linux/serial_core.h | 3 +
> > 4 files changed, 1098 insertions(+)
> > create mode 100644 drivers/tty/serial/sifive.c
>
> Seems like the 0-day bot did not like this driver, can you fix up those
> build errors and resend?

Nevermind, you did, sorry about that...