Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

[gregkh@xxxxxxxxxxxxxxxxxxx]

On Sun, Nov 11, 2018 at 04:18:03AM +0000, Dexuan Cui wrote:
> > From: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Thursday, November 1, 2018 21:54
> > To: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > Cc: Michael Kelley <mikelley@xxxxxxxxxxxxx>; KY Srinivasan
> > <kys@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> > jasowang@xxxxxxxxxx; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>;
> > vkuznets <vkuznets@xxxxxxxxxx>; Sasha Levin
> > <Alexander.Levin@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>;
> > Stable@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused
> > by incorrect clean-up
> > 
> > On Thu, Nov 01, 2018 at 07:22:28PM +0000, Dexuan Cui wrote:
> > > > From: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > Sent: Thursday, November 1, 2018 11:57
> > > > To: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > > >
> > > > On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote:
> > > > > > From: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> > > > > > Sent: Wednesday, October 24, 2018 08:38
> > > > > > From: kys@xxxxxxxxxxxxxxxxx <kys@xxxxxxxxxxxxxxxxx>  Sent:
> > > > Wednesday,
> > > > > > October 17, 2018 10:10 PM
> > > > > > > From: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > > > > > >
> > > > > > > In kvp_send_key(), we do need call process_ib_ipinfo() if
> > > > > > > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it
> > turns
> > > > out
> > > > > > > the userland hv_kvp_daemon needs the info of operation, adapter_id
> > > > and
> > > > > > > addr_family. With the incorrect fc62c3b1977d, the host can't get the
> > > > > > > VM's IP via KVP.
> > > > > > >
> > > > > > > And, fc62c3b1977d added a "break;", but actually forgot to initialize
> > > > > > > the key_size/value in the case of KVP_OP_SET, so the default key_size
> > of
> > > > > > > 0 is passed to the kvp daemon, and the pool files
> > > > > > > /var/lib/hyperv/.kvp_pool_* can't be updated.
> > > > > > >
> > > > > > > This patch effectively rolls back the previous fc62c3b1977d, and
> > > > > > > correctly fixes the "this statement may fall through" warnings.
> > > > > > >
> > > > > > > This patch is tested on WS 2012 R2 and 2016.
> > > > > > >
> > > > > > > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may
> > fall
> > > > > > through" warnings")
> > > > > > > Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > > > > > > Cc: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > > > > > > Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > > > > > > Cc: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> > > > > > > Cc: <Stable@xxxxxxxxxxxxxxx>
> > > > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > > > > > > ---
> > > > > > >  drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++----
> > > > > > >  1 file changed, 22 insertions(+), 4 deletions(-)
> > > > > > >
> > > > > > Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> > > > >
> > > > > Hi Greg,
> > > > > Can you please take a look at this patch?
> > > >
> > > > Nope, I'm not the hv maintainer, they need to look at this and ack it,
> > > > not me :)
> > > >
> > > > greg k-h
> > >
> > > Hi Greg,
> > > KY has added his Signed-off-by in the mail.
> > >
> > > I'll ask the other HV maintainers to take a look as well.
> > 
> > Ok, then I'll look at it after 4.20-rc1 is out, nothing I can do until
> > then anyway...
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> Can you please take a look at the patch now?

It's in my queue, sorry, it's big right now due to travel...