RE: [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup support

[Joakim Zhang]

> -----Original Message-----
> From: Shawn Guo <shawnguo@xxxxxxxxxx>
> Sent: 2018年11月4日 15:40
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> Cc: s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Fabio Estevam
> <fabio.estevam@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
> robh+dt@xxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; A.s. Dong
> <aisheng.dong@xxxxxxx>
> Subject: Re: [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup
> support
> 
> On Tue, Oct 23, 2018 at 05:30:44AM +0000, Joakim Zhang wrote:
> > From: Dong Aisheng <aisheng.dong@xxxxxxx>
> >
> > Add stop-mode property which is required by stop mode wakeup feature.
> >
> > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> > ---
> >  arch/arm/boot/dts/imx6sx.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6sx.dtsi
> > b/arch/arm/boot/dts/imx6sx.dtsi index 844caa39364f..3f459d6da7fc
> > 100644
> > --- a/arch/arm/boot/dts/imx6sx.dtsi
> > +++ b/arch/arm/boot/dts/imx6sx.dtsi
> > @@ -448,6 +448,7 @@
> >  				clocks = <&clks IMX6SX_CLK_CAN1_IPG>,
> >  					 <&clks IMX6SX_CLK_CAN1_SERIAL>;
> >  				clock-names = "ipg", "per";
> > +				stop-mode = <&gpr 0x10 1 0x10 17>;
> 
> Is it supported by upstream?  I cannot find this property in ether flexcan
> bindings doc or kernel driver.
> 
> Shawn

Hi Shawn,
This property has been reviewed by maintainer in flexcan bindings and kernel driver has sent to review.

Best Regards,
Joakim Zhang

> >  				status = "disabled";
> >  			};
> >
> > @@ -458,6 +459,7 @@
> >  				clocks = <&clks IMX6SX_CLK_CAN2_IPG>,
> >  					 <&clks IMX6SX_CLK_CAN2_SERIAL>;
> >  				clock-names = "ipg", "per";
> > +				stop-mode = <&gpr 0x10 2 0x10 18>;
> >  				status = "disabled";
> >  			};
> >
> > --
> > 2.17.1
> >