Re: [PATCH] media: venus: amend buffer size for bitstream plane

[Stanimir Varbanov]

Hi Tomasz,

On 10/23/2018 05:50 AM, Tomasz Figa wrote:
> Hi Malathi,
> 
> On Tue, Oct 9, 2018 at 4:58 PM Malathi Gottam <mgottam@xxxxxxxxxxxxxx> wrote:
>>
>> For lower resolutions, incase of encoder, the compressed
>> frame size is more than half of the corresponding input
>> YUV. Keep the size as same as YUV considering worst case.
>>
>> Signed-off-by: Malathi Gottam <mgottam@xxxxxxxxxxxxxx>
>> ---
>>  drivers/media/platform/qcom/venus/helpers.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
>> index 2679adb..05c5423 100644
>> --- a/drivers/media/platform/qcom/venus/helpers.c
>> +++ b/drivers/media/platform/qcom/venus/helpers.c
>> @@ -649,7 +649,7 @@ u32 venus_helper_get_framesz(u32 v4l2_fmt, u32 width, u32 height)
>>         }
>>
>>         if (compressed) {
>> -               sz = ALIGN(height, 32) * ALIGN(width, 32) * 3 / 2 / 2;
>> +               sz = ALIGN(height, 32) * ALIGN(width, 32) * 3 / 2;
>>                 return ALIGN(sz, SZ_4K);
>>         }
> 
> Note that the driver should not enforce one particular buffer size for
> bitstream buffers unless it's a workaround for broken firmware or
> hardware. The userspace should be able to select the desired size.

Good point! Yes, we have to extend set_fmt to allow bigger sizeimage for
the compressed buffers (not only for encoder).

-- 
regards,
Stan