Re: [PATCH v3 0/4] Correct dma pool for imx-sdma
From: Lucas Stach
Date: Mon Nov 12 2018 - 10:56:32 EST
Hi Robin,
Am Dienstag, den 06.11.2018, 03:40 +0000 schrieb Robin Gong:
> This patch set to correct dma pool used in the commit fe5b85c656bc
> ("dmaengine: imx-sdma: alloclate bd memory from dma pool")
> because all bds should be contiguous in memory in multi bds case
> for sdma, but dma pool can't statify it and cause transfer failure
> then.Thank Lucas for the making things on the right way.
>
> This patch set is v3 based on Lucas's V1/V2, the main refine:
> Â --fix the issue I reported in V1 but Lucas workaround it by improper
> ÂÂÂÂway in V2.
> Â --add vchan_synchronize() to kill tasklet in virt-dma internal.
> Â --refine name: use sdma_disable_channel_async instead of
> ÂÂÂÂsdma_disable_channel_with_delay since no delay indeed for
> ÂÂÂÂdevice_terminate_all.
> Please refer to below link for more information:
> https://patchwork.kernel.org/patch/10601111
Thanks for taking care of those. I've tested them on my board and
things seem to work fine for all my use-cases.
I think those patches should get a CC to stable 4.19. I guess Vinod can
add this when applying the patchset.
Regards,
Lucas