Re: [PATCH] scsi: libsas: Remove pcidev reference

From: John Garry
Date: Mon Nov 12 2018 - 14:32:08 EST


On 12/11/2018 18:58, Joe Perches wrote:
+#define pr_fmt(fmt) "sas: " fmt
>
> Some other subsystem may try to include this header, and gets its
> message prefix overwritten. Just a consequence for doing something bad,
> right?
Right.

And as this file is internal to drivers/scsi/libsas
that seems very unlikely to occur.

It also might useful to use the common debugging
mechanisms and convert SAS_DPRINTK to pr_debug
which would use the same #define pr_fmt.


OK, I will try to put this all together as a marginally wider scope tidy-up.

Cheers,
John