Re: [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding

From: Shawn Guo
Date: Tue Nov 13 2018 - 00:00:14 EST


Hi Sriharsha,

On Tue, Nov 13, 2018 at 11:42 AM Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
<snip>
> > > +- qcom,init-seq:
> > > + Value type: <u32 array>
> > > + Definition: Should contain a sequence of <offset value delay> tuples to
> > > + program 'value' into phy register at 'offset' with 'delay'
> > > + in us afterwards.
> >
> > If we wanted this type of thing in DT, we'd have a generic binding (or
> > forth).
>
> Right now, this is a qualcomm usb phy specific bindings - first used in
> qcom,usb-hs-phy.txt and I extended it a bit for my phy. As this is not
> a so good hardware description, I'm a little hesitated to make it
> generic for other platforms to use in general. What about we put off it
> a little bit until we see more platforms need the same thing?

Are those register write sequences really required here? At least,
from the test I do, it still works with this property dropped.

Shawn