Re: [PATCH 1/3] regulator: dt-bindings: add MCP16502 regulator bindings

[Mark Brown]

On Tue, Nov 13, 2018 at 11:29:24AM +0000, Andrei.Stefanescu@xxxxxxxxxxxxx wrote:

> +- lpm-gpio: GPIO for LPM pin. Note that this GPIO *must* remain high during
> +	     suspend-to-ram, keeping the PMIC into HIBERNATE mode.

All GPIO properties should be -gpios even if they can only ever have one
GPIO.

> +- regulators: A node that houses a sub-node for each regulator within
> +              the device. Each sub-node is identified using the node's
> +              name. The content of each sub-node is defined by the
> +              standard binding for regulators; see regulator.txt.

You should describe which regulators exist for the device.

Attachment: signature.asc
Description: PGP signature