Re: [PATCH v3 3/3] b43: Use cordic algorithm from kernel library

[Michael BÃsch]

On Wed, 14 Nov 2018 20:27:52 +0200
Priit Laes <plaes@xxxxxxxxx> wrote:

> Kernel library has a common cordic algorithm which is identical
> to internally implementatd one, so use it and drop the duplicate
> implementation.


In v2 of the series it has been said that:

Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote:
> I recall doing a comparison between the algorithms and thought I put 
> that in the original commit message. However, it is not there. It is not 
> exactly the same as in b43 so there are difference for certain angles, 
> most results are the same however. This implementation is slightly more 
> accurate on the full scale.


That's not my definition of "identical".

Please do not apply this patch without doing a thorough regression test
on actual b43 LP hardware.


-- 
Michael

Attachment: pgp6buDkegD56.pgp
Description: OpenPGP digital signature