RE: [PATCH 15/23] dt-bindings: pci: mobiveil: change gpio_slave and apb_csr to optional
From: Z.q. Hou
Date: Wed Nov 14 2018 - 21:27:55 EST
Hi Subrahmanya,
Thanks a lot for your ACK!
Regards,
Zhiqiang
> -----Original Message-----
> From: Subrahmanya Lingappa <l.subrahmanya@xxxxxxxxxxxxxx>
> Sent: 2018å11æ14æ 17:33
> To: Z.q. Hou <zhiqiang.hou@xxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> shawnguo@xxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; Lorenzo Pieralisi
> <lorenzo.pieralisi@xxxxxxx>; Mingkai Hu <mingkai.hu@xxxxxxx>; M.h. Lian
> <minghuan.lian@xxxxxxx>; Xiaowei Bao <xiaowei.bao@xxxxxxx>
> Subject: Re: [PATCH 15/23] dt-bindings: pci: mobiveil: change gpio_slave and
> apb_csr to optional
>
> Acked-by: Subrahmanya Lingappa <l.subrahmanya@xxxxxxxxxxxxxx>
>
> On Tue, Nov 6, 2018 at 6:50 PM Z.q. Hou <zhiqiang.hou@xxxxxxx> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> >
> > Change the "gpio_slave" and "apb_csr" to optional, the "gpio_slave"
> > is not used in current code, and "apb_csr" is not used by some
> > platorms.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> > ---
> > Documentation/devicetree/bindings/pci/mobiveil-pcie.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt
> > b/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt
> > index a618d4787dd7..64156993e052 100644
> > --- a/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt
> > @@ -10,8 +10,10 @@ Required properties:
> > interrupt source. The value must be 1.
> > - compatible: Should contain "mbvl,gpex40-pcie"
> > - reg: Should contain PCIe registers location and length
> > + Mandatory:
> > "config_axi_slave": PCIe controller registers
> > "csr_axi_slave" : Bridge config registers
> > + Optional:
> > "gpio_slave" : GPIO registers to control slot power
> > "apb_csr" : MSI registers
> >
> > --
> > 2.17.1
> >