Re: [PATCH] mfd: qcom_rpm: write fw_version to CTRL_REG

[Lee Jones]

On Wed, 14 Nov 2018, Jonathan Marek wrote:

> downstream driver does this, and it is required on msm8060 (hp touchpad)

You can leave the bit about the downstream driver.

Please expand your commit message.  Why is it required?  What happens
if you don't have it?  What problem does it solve?  Exactly what is
happening to the H/W?

> Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> ---
>  drivers/mfd/qcom_rpm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 52fafea06067..8d420c37b2a6 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -638,6 +638,10 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  		return -EFAULT;
>  	}
>  
> +	writel(fw_version[0], RPM_CTRL_REG(rpm, 0));
> +	writel(fw_version[1], RPM_CTRL_REG(rpm, 1));
> +	writel(fw_version[2], RPM_CTRL_REG(rpm, 2));
> +
>  	dev_info(&pdev->dev, "RPM firmware %u.%u.%u\n", fw_version[0],
>  							fw_version[1],
>  							fw_version[2]);

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog