Re: [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA

[Dinh Nguyen]

On 11/15/18 9:34 AM, Philipp Zabel wrote:
> Hi Dinh,
> 
> On Tue, 2018-11-13 at 12:50 -0600, Dinh Nguyen wrote:
>> @@ -120,7 +120,8 @@ static const struct reset_simple_devdata reset_simple_active_low = {
>>  };
>>  
>>  static const struct of_device_id reset_simple_dt_ids[] = {
>> -	{ .compatible = "altr,rst-mgr", .data = &reset_simple_socfpga },
>> +	{ .compatible = "altr,stratix10-rst-mgr", "altr,rst-mgr",
> 
> This should be
> 
> +ÂÂÂÂÂÂÂ{ .compatible = "altr,stratix10-rst-mgr",
> 
> instead. The rest looks good to me. If you are ok with this change, I
> can fix it up when applying.
> 

Sure..thanks,
Dinh