Re: [PATCH] geneve: Add missing braces in addr6 initializer

From: David Miller
Date: Thu Nov 15 2018 - 14:35:06 EST


From: Nathan Chancellor <natechancellor@xxxxxxxxx>
Date: Mon, 12 Nov 2018 15:12:48 -0700

> Clang warns:
>
> drivers/net/geneve.c:428:29: error: suggest braces around initialization
> of subobject [-Werror,-Wmissing-braces]
> struct in6_addr addr6 = { 0 };
> ^
> {}
>
> Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

And this makes GCC warn.

drivers/net/geneve.c: In function âgeneve_udp_encap_err_lookupâ:
drivers/net/geneve.c:428:27: warning: missing braces around initializer [-Wmissing-braces]
struct in6_addr addr6 = { { 0 } };
^
{ }

ïâÂâÂïâï âââ