RE: [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile
From: y-goto@xxxxxxxxxxx
Date: Thu Nov 15 2018 - 22:08:11 EST
Hi, Dan-san,
Thank you for your patch. I have one comment.
> ---
> Documentation/nvdimm/subsystem-profile.rst | 86 ++++++++++++++++++++++++++++
> MAINTAINERS | 4 +
> 2 files changed, 90 insertions(+)
> create mode 100644 Documentation/nvdimm/subsystem-profile.rst
>
> diff --git a/Documentation/nvdimm/subsystem-profile.rst b/Documentation/nvdimm/subsystem-profile.rst
> new file mode 100644
> index 000000000000..d3428be7528e
> --- /dev/null
> +++ b/Documentation/nvdimm/subsystem-profile.rst
> @@ -0,0 +1,86 @@
> +LIBNVDIMM Subsystem Profile
> +===========================
> +
> +Overview
> +--------
> +So, you have recently become a maintainer of the LIBNVDIMM subsystem,
> +condolences, it is a thankless job, here is the lay of the land. The git
Here, I think that more positive sentence is desirable to encourage new comer.
Certainly, I can imagine that maintainer is hard and tough work,
but I believe it is great work.
Even if this is irony or joke, then it may be cause of miss-understanding
(especially, non-native English speaker like me.)
In addition, new coming developer is sometimes nervous
to post new mail/patch. If this text will be changed for new comer,
then I think this text will be good to encourage them.
So, I think more positive expression is desirable.
Thanks,