Re: [PATCH 2/3] pinctrl: stm32: protect configuration registers with a hwspinlock
From: Linus Walleij
Date: Mon Nov 19 2018 - 07:21:02 EST
On Tue, Nov 13, 2018 at 10:51 AM Benjamin Gaignard
<benjamin.gaignard@xxxxxxxxxx> wrote:
> If a hwspinlock if defined in device tree use it to protect
> configuration registers.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
Patch applied with Alex' ACK.
Out of curiosity: what is it protecting against?
I would guess simultaneous access from another CPU
but the commit doesn't say.
Simultaneous access from two CPUs makes it extra important
that all register access is read-modify-write, so I'd have a second
check over the code to make sure this is the case.
Yours,
Linus Walleij