Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND

[Otavio Salvador]

Hello Fabio,
On Sun, Nov 25, 2018 at 6:30 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
> On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@xxxxxxxxxxxxxxxx> wrote:
> >
> > The setting is removed when running a `savedefconfig` using the
> > current setting set. It is being applied in preparation to some
>
> "setting set" is a bit confusing.
>
> > patches making changes to this defconfig.
>
> It would be good to mention that CONFIG_ARM_UNWIND is still selected
> automatically.
>
> Otherwise it may give the impression that such functionality is being removed.
>
> You could reword the commit log to something like this:
>
> CONFIG_ARM_UNWIND is removed when running  'savedefconfig', but it is
> still selected by the Kconfig logic.
> This is done in preparation to making further changes to this defconfig cleaner.

In fact, was removed and now selected.

I changed the commit log as:

ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable

CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
selected by the Kconfig logic.  This is done in preparation to making
further changes to this defconfig cleaner.

Do you agree?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750