Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

From: Mark Brown
Date: Tue Nov 27 2018 - 06:50:47 EST


On Mon, Nov 26, 2018 at 06:46:05PM +0000, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx>
> ---

This really needs a changelog to explain what is going on here, and we
need some more documentation in the code. It is *extremely* unusual to
have to poll for reset like this, and if the failure mode is I/O errors
that's going to be pretty painful.

Attachment: signature.asc
Description: PGP signature