RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

[Ryan Lee]

>-----Original Message-----
>From: Mark Brown <broonie@xxxxxxxxxx>
>Sent: Tuesday, November 27, 2018 3:51 AM
>To: Ryan Lee <RyanS.Lee@xxxxxxxxxxxxxxxxxxx>
>Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>; Jaroslav Kysela
><perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Grant Grundler
><grundler@xxxxxxxxxxxx>; Kuninori Morimoto
><kuninori.morimoto.gx@xxxxxxxxxxx>; Benson Leung
><bleung@xxxxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp
>reset
>
>On Mon, Nov 26, 2018 at 06:46:05PM +0000, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx>
>> ---
>
>This really needs a changelog to explain what is going on here, and we need
>some more documentation in the code.  It is *extremely* unusual to have to
>poll for reset like this, and if the failure mode is I/O errors that's going to be
>pretty painful.
OK. I agree that this is very unusual. I wanted to make this code change very conservative and this caused unusual overhead.
Let me fix this.