Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros

[Nadav Amit]

> On Nov 28, 2018, at 3:09 PM, Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:
> 
> 
> 
> On 2018-11-14 6:57 p.m., Nadav Amit wrote:
>> Eventually, if you get a fix into icecc, we will need to change the
>> Makefile, consider the version number and act accordingly.
> 
> I got a fix pulled into icecc[1] and it works quite well. It ought to be
> included in the next version of icecc. And distcc (with pump at least)
> has a patch too. In my experience, icecc does a much better job
> distributing the kernel build though.
> 
> Logan
> 
> [1] https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ficecc%2Ficecream%2Fpull%2F430&amp;data=02%7C01%7Cnamit%40vmware.com%7C044d795be30143ae26ef08d65586953b%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636790433884222635&amp;sdata=4h72yLjvOF29kcAC5CM7CB9ukH3HoALNUfgKA62E4Gs%3D&amp;reserved=0

Thanks for taking care of it. This change is certainly simpler and cleaner
than the one I came with.

So whatâs your take? Would you think this patch is still needed? Should it
only be enabled automatically for distcc and not for distcc-pump?