Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros

From: Logan Gunthorpe
Date: Wed Nov 28 2018 - 19:49:43 EST




On 2018-11-28 5:38 p.m., Nadav Amit wrote:
> So whatâs your take? Would you think this patch is still needed? Should it
> only be enabled automatically for distcc and not for distcc-pump?

Not sure. The patch will probably slow things down a lot (seeing
assembly is always done locally and there are twice as many compile
steps) and will create some confusion once it's possible to disable it
for the new versions. Maybe hold off and see if anyone else complains?

I don't really know how you'd detect whether pump is in use or not and
I'm uncertain as to whether any of the auto detection can actually be
made to be reliable.

Logan