Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code

[Lee Jones]

On Sun, 02 Dec 2018, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_STA2X11
> drivers/mfd/Kconfig:    bool "STMicroelectronics STA2X11"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> We replace module.h with init.h and export.h ; the latter since the
> file does export some symbols.
> 
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>

I think you should add some of the driver developers.

> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
>  drivers/mfd/sta2x11-mfd.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog