Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code

From: Paul Gortmaker
Date: Mon Dec 03 2018 - 10:09:17 EST


[Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code] On 03/12/2018 (Mon 11:14) Lee Jones wrote:

> On Sun, 02 Dec 2018, Paul Gortmaker wrote:
>
> > The Kconfig currently controlling compilation of this code is:
> >
> > drivers/mfd/Kconfig:config MFD_STA2X11
> > drivers/mfd/Kconfig: bool "STMicroelectronics STA2X11"
> >
> > ...meaning that it currently is not being built as a module by anyone.
> >
> > Lets remove the couple traces of modular infrastructure use, so that
> > when reading the driver there is no doubt it is builtin-only.

[...]

> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
>
> I think you should add some of the driver developers.

Fair point, but note that get_maintainers doesn't list any developers,
and neither of the driver authors put an e-mail address in the driver.


$ gm drivers/mfd/sta2x11-mfd.c
------------------------------------------------------
Lee Jones <lee.jones@xxxxxxxxxx> (supporter:MULTIFUNCTION DEVICES (MFD))
linux-kernel@xxxxxxxxxxxxxxx (open list)
------------------------------------------------------
Cc: Lee Jones <lee.jones@xxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
------------------------------------------------------
$

Looking in git history, I was able to find two e-mail, but one hasn't
been used in 5+ years, so hopefully it is still active. I have added
both to the Cc: of this e-mail and added them to the commit below.

Alessandro, Davide - you can find additional context regarding why we
are making these changes in the [00/22] e-mail that can be found here:

https://lore.kernel.org/lkml/1543811009-15112-1-git-send-email-paul.gortmaker@xxxxxxxxxxxxx/

Thanks,
Paul.

--