Re: [PATCH v2 4/8] dma-debug: Dynamically expand the dma_debug_entry pool

From: Christoph Hellwig
Date: Thu Dec 06 2018 - 09:24:26 EST


> @@ -47,6 +47,8 @@
> #ifndef PREALLOC_DMA_DEBUG_ENTRIES
> #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
> #endif

FYI, I think we should drop the potential arch hook with the ifndef
here once we support the dynamic adjustment.

> + if (dma_debug_create_entries(DMA_DEBUG_DYNAMIC_ENTRIES, GFP_ATOMIC)) {

Overly long line.