Re: [PATCH v2 4/8] dma-debug: Dynamically expand the dma_debug_entry pool

[Robin Murphy]

On 06/12/2018 14:24, Christoph Hellwig wrote:
> > @@ -47,6 +47,8 @@
> >   #ifndef PREALLOC_DMA_DEBUG_ENTRIES
> >   #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
> >   #endif
>
> FYI, I think we should drop the potential arch hook with the ifndef
> here once we support the dynamic adjustment.

Sure - I have a vague feeling that thought did cross my mind at the 
time, but it didn't stick.

> > +		if (dma_debug_create_entries(DMA_DEBUG_DYNAMIC_ENTRIES, GFP_ATOMIC)) {
>
> Overly long line.

Bah, I deliberately didn't bother wrapping this since it gets shorter 
again later, but now I realise it also slipped through the s/create/add/ 
rebase so it's just busted, and due to another last-minute fix I 
actually ended up with an even longer line elsewhere.

I'll tidy all of that up for a v3.

Robin.