Re: [RFC PATCH] PM / OPP: Always expose one supply in debugfs
From: Viresh Kumar
Date: Tue Dec 11 2018 - 06:27:28 EST
On 11-12-18, 09:49, Quentin Perret wrote:
> So, on Juno we do get voltage numbers from firmware, and those get
> registered properly in PM_OPP, exactly like for Hikey960. So it's
> probably the same problem in both cases.
>
> FWIW, this is what I get on juno with my 'fix' applied:
>
> $ cat /sys/kernel/debug/opp/cpu0/*/supply-0/u_volt_target
> 820000
> 850000
> 900000
> 950000
> 1000000
>
> > Anyway, this should still be fixed irrespective of the "cpu-supply" property.
> > The other fix you mentioned about setting opp_table->regulator_count to 1 is
> > actually the right thing to do but the fix may require changes at multiple
> > places. I can help writing a patch for that if you want, else I am open to you
> > giving it a shot :)
>
> You'll definitely know the code better than me so if you have a patch in
> mind, please don't hesitate. I'll be happy to test it on my two boards
> here :-)
Sent some patches, please give them a try.
--
viresh