Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports
From: Russell King - ARM Linux
Date: Tue Dec 11 2018 - 13:52:15 EST
On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote:
> That is, something like this, right?
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 125ea99418df..04cb0241ca2b 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -4404,13 +4404,18 @@ static void mvpp2_phylink_validate(struct net_device *dev,
> switch (state->interface) {
> case PHY_INTERFACE_MODE_10GKR:
> case PHY_INTERFACE_MODE_XAUI:
> + if (port->gop_id != 0)
> + goto empty_set;
> + /* Fall-through */
> case PHY_INTERFACE_MODE_NA:
> - phylink_set(mask, 10000baseCR_Full);
> - phylink_set(mask, 10000baseSR_Full);
> - phylink_set(mask, 10000baseLR_Full);
> - phylink_set(mask, 10000baseLRM_Full);
> - phylink_set(mask, 10000baseER_Full);
> - phylink_set(mask, 10000baseKR_Full);
> + if (port->gop_id == 0) {
> + phylink_set(mask, 10000baseCR_Full);
> + phylink_set(mask, 10000baseSR_Full);
> + phylink_set(mask, 10000baseLR_Full);
> + phylink_set(mask, 10000baseLRM_Full);
> + phylink_set(mask, 10000baseER_Full);
> + phylink_set(mask, 10000baseKR_Full);
> + }
> /* Fall-through */
> case PHY_INTERFACE_MODE_RGMII:
> case PHY_INTERFACE_MODE_RGMII_ID:
>
Yep, looks fine to me, thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up