Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.

From: Kevin Hilman
Date: Tue Dec 11 2018 - 13:53:10 EST


Thomas Meyer <thomas@xxxxxxxx> writes:

> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>

Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>

> ---
>
> diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
>
> if (sr_info->autocomp_active)
> sr_stop_vddautocomp(sr_info);
> - if (sr_info->dbg_dir)
> - debugfs_remove_recursive(sr_info->dbg_dir);
> + debugfs_remove_recursive(sr_info->dbg_dir);
>
> pm_runtime_disable(&pdev->dev);
> list_del(&sr_info->node);