Re: [PATCH 6/6] tools gpio: Override CFLAGS assignments

From: Jiri Olsa
Date: Thu Dec 13 2018 - 06:23:50 EST


On Wed, Dec 12, 2018 at 03:15:01PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 12, 2018 at 11:25:37AM +0100, Jiri Olsa wrote:
> > So user could specify outside CFLAGS values.
>
> For all three where I'm in Cc list
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

thanks, I should have cc-ed you on all of them ;-)

any idea who could I ask to pull these in?

thanks,
jirka

>
> >
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> > Cc: Hartmut Knaack <knaack.h@xxxxxx>
> > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > ---
> > tools/gpio/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
> > index 240eda014b37..6ecdd1067826 100644
> > --- a/tools/gpio/Makefile
> > +++ b/tools/gpio/Makefile
> > @@ -12,7 +12,7 @@ endif
> > # (this improves performance and avoids hard-to-debug behaviour);
> > MAKEFLAGS += -r
> >
> > -CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
> > +override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
> >
> > ALL_TARGETS := lsgpio gpio-hammer gpio-event-mon
> > ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
> > --
> > 2.17.2
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>