Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

[Christophe Leroy]

Hi Again,

Le 13/12/2018 Ã 13:16, Christophe Leroy a ÃcritÂ:
> Hi,
>
> On 12/03/2018 09:55 PM, Jonathan NeuschÃfer wrote:
> > Hi,
> >
> > On Thu, Nov 29, 2018 at 07:00:16PM +0000, Christophe Leroy wrote:
> > > This patch reworks mmu_mapin_ram() to be more generic and map as much
> > > blocks as possible. It now supports blocks not starting at address 0.
> > >
> > > It scans DBATs array to find free ones instead of forcing the use of
> > > BAT2 and BAT3.
> > >
> > > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> > > ---
> >
> > I've just tested this series on my Wii, and starting from this patch
> > (03/13), it hangs at the following lines of output:
> >
> > [ÂÂÂ 0.000000] printk: bootconsole [udbg0] enabled
> > [ÂÂÂ 0.000000] Total memory = 319MB; using 1024kB for hash table (at 
> > (ptrval))
> >
> > Before this patch it looks like this and boots to userspace:
> >
> > [ÂÂÂ 0.000000] printk: bootconsole [udbg0] enabled
> > [ÂÂÂ 0.000000] Total memory = 319MB; using 1024kB for hash table (at 
> > (ptrval))
> > [ÂÂÂ 0.000000] Linux version 4.20.0-rc5-wii-00022-gfbb911b84755 
> > (jn@longitude) (gcc version 8.2.0 (Debian 8.2.0-9)) #1337 PREEMPT Mon 
> > Dec 3 21:49:02 CET 2018
> > ug_udbg_init: early -> final
> > usbgecko_udbg: ready
> > [ÂÂÂ 0.000000] Using wii machine description
>
> Can you tell/provide the .config and dts used ?
>
> You seem to have 319MB RAM wherease arch/powerpc/boot/dts/wii.dts only 
> has 88MB Memory:
>
>  ÂÂÂÂmemory {
>  ÂÂÂÂÂÂÂ device_type = "memory";
>  ÂÂÂÂÂÂÂ reg = <0x00000000 0x01800000ÂÂÂ /* MEM1 24MB 1T-SRAM */
>  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ 0x10000000 0x04000000>;ÂÂÂ /* MEM2 64MB GDDR3 */
>  ÂÂÂÂ};

Putting the same description in my mpc832x board DTS and doing a few 
hacks to get the WII functions called, I get the following:

[    0.000000] Top of RAM: 0x14000000, Total RAM: 0x5800000
[    0.000000] Memory hole size: 232MB
[    0.000000] Zone ranges:
[    0.000000]   DMA      [mem 0x0000000000000000-0x0000000013ffffff]
[    0.000000]   Normal   empty
[    0.000000] Movable zone start for each node
[    0.000000] Early memory node ranges
[    0.000000]   node   0: [mem 0x0000000000000000-0x00000000017fffff]
[    0.000000]   node   0: [mem 0x0000000010000000-0x0000000013ffffff]
[    0.000000] Initmem setup node 0 [mem 
0x0000000000000000-0x0000000013ffffff]
[    0.000000] On node 0 totalpages: 22528
[    0.000000]   DMA zone: 640 pages used for memmap
[    0.000000]   DMA zone: 0 pages reserved
[    0.000000]   DMA zone: 22528 pages, LIFO batch:3
[    0.000000] pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768
[    0.000000] pcpu-alloc: [0] 0
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 21888
[    0.000000] Kernel command line: loglevel=7 
ip=192.168.2.5:192.168.2.2::255.0
[    0.000000] Dentry cache hash table entries: 16384 (order: 4, 65536 
bytes)
[    0.000000] Inode-cache hash table entries: 8192 (order: 3, 32768 bytes)
[    0.000000] Memory: 77060K/90112K available (6548K kernel code, 1156K 
rwdata,
[    0.000000] Kernel virtual memory layout:
[    0.000000]   * 0xfffdf000..0xfffff000  : fixmap
[    0.000000]   * 0xfdffd000..0xfe000000  : early ioremap
[    0.000000]   * 0xd5000000..0xfdffd000  : vmalloc & ioremap




root@vgoippro:~# cat /sys/kernel/debug/powerpc/block_address_translation
---[ Instruction Block Address Translation ]---
0: 0xc0000000-0xc0ffffff 0x00000000 Kernel EXEC coherent
1:         -
2: 0xc1000000-0xc17fffff 0x01000000 Kernel EXEC coherent
3:         -
4: 0xd0000000-0xd3ffffff 0x10000000 Kernel EXEC coherent
5:         -
6:         -
7:         -

---[ Data Block Address Translation ]---
0: 0xc0000000-0xc0ffffff 0x00000000 Kernel RW coherent
1: 0xfffe0000-0xffffffff 0x0d000000 Kernel RW no cache guarded
2: 0xc1000000-0xc17fffff 0x01000000 Kernel RW coherent
3:         -
4: 0xd0000000-0xd3ffffff 0x10000000 Kernel RW coherent
5:         -
6:         -
7:         -


Could you please provide the dmesg and 
/sys/kernel/debug/powerpc/block_address_translation from before this 
patch, so that we can compare and identify the differences if any ?

Thanks
Christophe



> Christophe
>
> > ...
> >
> > I've tested at patch 1, 2, 3, 4, and 13, so I don't know if it works
> > somewhere in the middle, but probably not.
> >
> > (And in case you're wondering about the 22 in the version string: Those
> > are mostly patches that give me a serial console.)
> >
> > I'm not sure what is going on, because I haven't looked closely at the
> > patches or tried to debug the problem. If you have some debugging tips,
> > I can try them.
> >
> >
> > Jonathan NeuschÃfer