Re: [PATCH] brcmfmac: fix false-positive -Wmaybe-unintialized warning

From: Kalle Valo
Date: Thu Dec 13 2018 - 09:52:35 EST

Arnd Bergmann <arnd@xxxxxxxx> wrote:

> When CONFIG_NO_AUTO_INLINE is set, we get a false-postive warning
> for the brcmf_fw_request_nvram_done() function, after gcc figures
> out that brcmf_fw_nvram_from_efi() might not set the 'data_len'
> variable, but fails to notice that it always returns NULL:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c: In function 'brcmf_fw_request_nvram_done':
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:560:11: error: 'data_len' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> Mark it 'inline' to force gcc to understand this.
> Fixes: ce2e6db554fa ("brcmfmac: Add support for getting nvram contents from EFI variables")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Commit ce2e6db554fa is in w-d-next so this should go to that tree as well.