Re: [PATCH v14 03/11] livepatch: Consolidate klp_free functions

From: Josh Poimboeuf
Date: Thu Dec 13 2018 - 17:35:43 EST

On Mon, Dec 03, 2018 at 03:59:57PM +0100, Miroslav Benes wrote:
> On Thu, 29 Nov 2018, Petr Mladek wrote:
> > -static int klp_init_patch(struct klp_patch *patch)
> > +/* Init operations that must succeed before klp_free_patch() can be called. */
> > +static int klp_init_patch_before_free(struct klp_patch *patch)
> There is no klp_free_patch() now, so the comment is not correct. Also I
> don't know if the function name is ideal, but I don't have a better one.

Yeah, I found the name of this function to be confusing. It sounds like
you're initializing the patch before freeing it, which seems like an
obvious thing to do :-)

How about klp_init_patch_early()?