Re: [PATCH v10 17/27] drivers: firmware: psci: Prepare to support PM domains
From: Ulf Hansson
Date: Thu Dec 20 2018 - 16:38:23 EST
On Thu, 20 Dec 2018 at 19:06, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
> On 20/12/2018 16:49, Ulf Hansson wrote:
> [ ... ]
> >>> +#ifdef CONFIG_CPU_IDLE
> >> It would be nicer if you can remove the CONFIG_CPU_IDLE by replacing it
> >> with a specific one (eg. CONFIG_PSCI_IDLE) and make it depend on
> >> CONFIG_CPU_IDLE, so the config options stay contained in their
> >> respective subsystems directory.
> > I am all for simplifying the Kconfig options in here, as indeed it's
> > rather messy. However, I would rather avoid folding in additional
> > cleanup changes to this series, is already extensive enough.
> > Would you be okay if we deal with that on top?
> IMO, there are patches in this series which can be grouped into a
> cleanup + set the scene patchset and merged immediately. An option
> similar to ARM_SCMI_POWER_DOMAIN can be part of it.
I certainly agree to that. The tricky is, to know what pieces people
are happy with to go in. :-)
Earlier, in v9 I tried your suggested approach (kind of), but then
Lorenzo stated that it's kind of all or nothing. Maybe we can bring up
that discussion again with him and see what we can figure out.
> However, if you swear you will do the change after and sign with your
> blood, I'm fine with that 0:)
Whatever it takes!
Anyway, as stated, the reason why I want to tackle that on top, is
that I don't want to make the series more extensive than it already